Expo plugin: onNewIntent Method Conflict in Android MainActivity#13
Merged
Conversation
Owner
|
Thank you @descorp for your contribution. If the onNewIntent method already exists for another purpose, a soft modification could lead to code that compiles but causes runtime issues, either breaking this library or others that rely on the same method. In my opinion, it’s safer for the plugin to fail explicitly in such cases, leaving it to the developer using the package to handle this integration manually. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've encountered a compatibility issue when using this package alongside other libraries that also need to handle new intents in the Android MainActivity.
I would like to suggest a use of a default signature of kotlin method.
For a more robust long-term solution, I suggest modifying the Expo plugin to perform a "soft" modification.:
onNewIntentimplementation inMainActivity.kt.